Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator

Tmbox template not displayed on WMF wikis on mobile (MinervaNeue skin)
Closed, ResolvedPublic

Description

Opinions gathered to make it visible on mobile in kowiki. https://ko.wikipedia.org/wiki/틀토론:Tmbox#Tmbox의_모바일_표시_문제 we want to solve this problem.

QA steps

image.png (565×366 px, 210 KB)

Event Timeline

Aklapper updated the task description. (Show Details)

Hi @Gomdoli4696, thanks for taking the time to report this and welcome to Wikimedia Phabricator! Please always follow https://www.mediawiki.org/wiki/How_to_report_a_bug and explain which "Mobile Display Problems" you are facing, and please use the "Preview" function to check that links are working.

Aklapper renamed this task from Mobile Display Problems in Tmbox to Tmbox template not displayed on kowiki on mobile (MinervaNeue skin).Jul 8 2020, 9:19 AM
This comment has been deleted.
Jdlrobson subscribed.

If you want to make this mobile friendly and display it I recommend using another class instead of tmbox. Too many projects use that in a non user friendly way however please note any change you make will currently need to involve a header while
T229725 is open

Aklapper renamed this task from Tmbox template not displayed on kowiki on mobile (MinervaNeue skin) to Tmbox template not displayed on WMF wikis on mobile (MinervaNeue skin).Jan 3 2022, 7:18 PM
Aklapper added subscribers: Huji, LordProfo, 4nn1l2, Jeeputer.

We actually had to override this rule in the patches for T312312 / T312309: Unify experience for making lead section content available on mobile talk pages:
https://gerrit.wikimedia.org/g/mediawiki/extensions/DiscussionTools/+/e0855e4f41e7402816b9a9079ec660c186319d71/modules/dt.init.less#754

I wonder whether it's needed at all, though. Both the old mobile talk page interface, and the new one in DiscussionTools, hide the contents of the lede section on talk pages (the new one adds a button to show it again). Do we really need the rule to hide this part of the lede "twice"? I think we could remove it…

Change 855724 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] hacks: Stop hiding .fmbox and .tmbox

https://gerrit.wikimedia.org/r/855724

Jdlrobson added a project: Editing-team.

This seems like a decision editing team should feel free to make on their own since it only seems to mostly impact talk pages and then only impacts the "read as wiki page" function.
There's only 173 pages in the article namespace that seem to use this template:
https://global-search.toolforge.org/?q=%5C%7B%5C%7B%5Bft%5Dmbox&regex=1&namespaces=0&title=

Will possibly involve some community liason work so I'll let you handle that as part of editing team sprint. Web team doesn't need to be involved in this.

Change 856928 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Remove override for Minerva hiding .tmbox, no longer needed

https://gerrit.wikimedia.org/r/856928

Change 855724 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] hacks: Stop hiding .fmbox and .tmbox

https://gerrit.wikimedia.org/r/855724

Change 856928 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove override for Minerva hiding .tmbox, no longer needed

https://gerrit.wikimedia.org/r/856928

Change 858310 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.10] Remove override for Minerva hiding .tmbox, no longer needed

https://gerrit.wikimedia.org/r/858310

Change 858310 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.10] Remove override for Minerva hiding .tmbox, no longer needed

https://gerrit.wikimedia.org/r/858310

Mentioned in SAL (#wikimedia-operations) [2022-11-17T14:13:49Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:858308|Make "Add topic" button sticky (T316175)]], [[gerrit:858309|CommentFormatter: Fix condition for lede button to consider new wrappers (T323171)]], [[gerrit:858310|Remove override for Minerva hiding .tmbox, no longer needed (T257394)]], [[gerrit:858311|CommentFormatter: Fix condition for lede button to consider table of contents (T323241)]], [[gerrit:858312

Mentioned in SAL (#wikimedia-operations) [2022-11-17T14:14:13Z] <urbanecm@deploy1002> urbanecm and matmarex: Backport for [[gerrit:858308|Make "Add topic" button sticky (T316175)]], [[gerrit:858309|CommentFormatter: Fix condition for lede button to consider new wrappers (T323171)]], [[gerrit:858310|Remove override for Minerva hiding .tmbox, no longer needed (T257394)]], [[gerrit:858311|CommentFormatter: Fix condition for lede button to consider table of contents (T323241)]], [[gerr

Change 858313 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@wmf/1.40.0-wmf.10] hacks: Stop hiding .fmbox and .tmbox

https://gerrit.wikimedia.org/r/858313

Change 858313 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.40.0-wmf.10] hacks: Stop hiding .fmbox and .tmbox

https://gerrit.wikimedia.org/r/858313

Mentioned in SAL (#wikimedia-operations) [2022-11-17T14:50:35Z] <urbanecm@deploy1002> Started scap: 4e419212: f659d88b: 65cd6881: 96e86cf: 5b94aca: 7a06c4b98: DiscussionTools, GlobalUsage, MinervaNeue backports (T316175, T323171, T257394, T323241)

Mentioned in SAL (#wikimedia-operations) [2022-11-17T14:55:04Z] <urbanecm@deploy1002> Finished scap: 4e419212: f659d88b: 65cd6881: 96e86cf: 5b94aca: 7a06c4b98: DiscussionTools, GlobalUsage, MinervaNeue backports (T316175, T323171, T257394, T323241) (duration: 04m 29s)

@matmarex Re: Tech News - What wording would you suggest as the content, and When should it be included? Thanks! (I believe this is related to the prior announcement in "Future changes" but I'm not sure how exactly.)

I actually forgot about that previous announcement, this is indeed related. I don't think it's worth repeating separately, sorry about the noise.

ppelberg claimed this task.