Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator
Create Task
Maniphest T263441

Clean up $wgExtraLanguageNames production config
Open, Stalled, Needs TriagePublic
Actions

Description

After T260118 (edit: and now T273627) is done, I’d like to simplify the $wgExtraLanguageNames configuration in production a little bit.

Details

SubjectRepoBranchLines +/-
Remove unused $wgExtraLanguageNames['qqq'] assignmentoperations/mediawiki-configmaster+0 -1
Remove $wmgExtraLanguageNames from InitialiseSettings.phpoperations/mediawiki-configmaster+0 -129
Remove $wmgExtraLanguageNames from InitialiseSettings-labs.phpoperations/mediawiki-configmaster+0 -9
DNM: Stop using $wmgExtraLanguageNames in CommonSettings.phpoperations/mediawiki-configmaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Sep 21 2020, 11:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2020, 11:41 AM
gerritbot added a comment.Sep 21 2020, 11:48 AM

Change 628773 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] Remove unused $wgExtraLanguageNames['qqq'] assignment

https://gerrit.wikimedia.org/r/628773

gerritbot added a project: Patch-For-Review.Sep 21 2020, 11:48 AM

Change 628774 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] Stop using $wmgExtraLanguageNames in CommonSettings.php

https://gerrit.wikimedia.org/r/628774

gerritbot added a comment.Sep 21 2020, 11:48 AM

Change 628775 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] Remove $wmgExtraLanguageNames from InitialiseSettings-labs.php

https://gerrit.wikimedia.org/r/628775

gerritbot added a comment.Sep 21 2020, 11:51 AM

Change 628776 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] Remove $wmgExtraLanguageNames from InitialiseSettings.php

https://gerrit.wikimedia.org/r/628776

Addshore moved this task from incoming to in progress on the Wikidata board.Oct 13 2020, 7:47 AM
Lucas_Werkmeister_WMDE added a subtask: T273627: Remove wmgExtraLanguageNames from Wikimedia production.Feb 2 2021, 3:07 PM
Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptFeb 2 2021, 3:07 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 2 2021, 3:07 PM
Addshore moved this task from Inbox to legacy-backlog on the [DEPRECATED] wdwb-tech board.Mar 15 2021, 5:47 PM
Addshore edited projects, added [DEPRECATED] wdwb-tech (legacy-backlog); removed [DEPRECATED] wdwb-tech.
Addshore subscribed.Mar 18 2021, 4:16 PM

@Lucas_Werkmeister_WMDE Are these all ready to be deployed?

Lucas_Werkmeister_WMDE added a comment.Mar 22 2021, 10:19 AM

No, they’re blocked on the subtask, T273627: Remove wmgExtraLanguageNames from Wikimedia production (which in turn is also blocked on other things, though hopefully not forever).

Addshore moved this task from legacy-backlog to Blocked on the [DEPRECATED] wdwb-tech board.Apr 12 2021, 8:45 AM
Addshore edited projects, added [DEPRECATED] wdwb-tech; removed [DEPRECATED] wdwb-tech (legacy-backlog).
Pppery changed the task status from Open to Stalled.Apr 1 2023, 7:38 PM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.
Lucas_Werkmeister_WMDE added a subscriber: Pppery.Apr 3 2023, 10:05 AM

@Pppery which improvement do you think the patches need? I don’t agree with this change.

Pppery added a comment.Apr 3 2023, 10:51 PM

I retagged the ticket because all four patches have merge conflicts, and also marked it as stalled because I interpreted your March 22, 2021 comment as saying that.

Lucas_Werkmeister_WMDE edited projects, added Patch-For-Review; removed Patch-Needs-Improvement.Apr 4 2023, 9:40 AM

Only two of the patches had actual merge conflicts, the other two just touched files that had been modified in the meantime, which Gerrit misreports as a conflict. I’ve rebased them all now. The first one, Remove unused $wgExtraLanguageNames 'qqq' assignment, should actually be ready for deployment at any time (the rest are indeed stalled).

Pppery unsubscribed.Apr 4 2023, 10:00 PM
Addshore unsubscribed.Jun 27 2023, 12:36 PM
gerritbot added a comment.Jan 17 2024, 2:02 PM

Change 628773 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove unused $wgExtraLanguageNames['qqq'] assignment

https://gerrit.wikimedia.org/r/628773

Stashbot added a comment.Jan 17 2024, 2:03 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-17T14:03:00Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Started scap: Backport for [[gerrit:628773|Remove unused $wgExtraLanguageNames['qqq'] assignment (T263441)]]

Stashbot added a comment.Jan 17 2024, 2:07 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-17T14:07:24Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 lucaswerkmeister-wmde: Backport for [[gerrit:628773|Remove unused $wgExtraLanguageNames['qqq'] assignment (T263441)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 17 2024, 2:14 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-17T14:14:07Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Finished scap: Backport for [[gerrit:628773|Remove unused $wgExtraLanguageNames['qqq'] assignment (T263441)]] (duration: 11m 07s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits