Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator
Create Task
Maniphest T282759

Remove box-shadow usage in Popups and GuidedTour
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

.box-shadow() LESS mixin is now obsolete as box-shadow is supported without any vendor prefix fallbacks.

To support the goal in T277819, we need to update our extensions.

Popups is the only extension that web maintains that uses the deprecated mixin
https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups/+/2f06a49a6ce63f66a7ba32162b77a968a3b38de6/src/ui/templates/popup/popup.less#23

We kinda support GuidedTour as we have @phuedx
https://gerrit.wikimedia.org/g/mediawiki/extensions/GuidedTour/+/433d6975a030314754113d3881b9375f2e52ada8/modules/ext.guidedTour.less#20

Gettingstarted can be ignored because of https://phabricator.wikimedia.org/T235752

Details

SubjectRepoBranchLines +/-
Remove obsolete LESS `box-shadow` mixinmediawiki/extensions/GuidedTourmaster+2 -2
Remove obsolete LESS `box-shadow` mixinmediawiki/extensions/GettingStartedmaster+2 -2
Remove obsolete box-shadow mixinmediawiki/extensions/Popupsmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson renamed this task from Remove box-shadow to Remove box-shadow usage in Popups.May 13 2021, 12:59 AM
Jdlrobson removed ovasileva as the assignee of this task.
Jdlrobson created this task.
Jdlrobson mentioned this in T277819: Deprecate and remove `.box-shadow()` mediawiki.mixin and remove callers.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson added a subscriber: ovasileva.
Jdlrobson renamed this task from Remove box-shadow usage in Popups to Remove box-shadow usage in Popups and GuidedTour.May 13 2021, 1:01 AM
Jdlrobson added a project: MediaWiki-extensions-GuidedTour.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: phuedx.
Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 13 2021, 1:01 AM
Jdlrobson renamed this task from Remove box-shadow usage in Popups and GuidedTour to Remove box-shadow usage in Popups, GettingStarted and GuidedTour.May 13 2021, 1:02 AM
Jdlrobson added a project: MediaWiki-extensions-GettingStarted.
Jdlrobson updated the task description. (Show Details)
ovasileva triaged this task as Medium priority.May 13 2021, 8:18 AM
Volker_E updated the task description. (Show Details)May 13 2021, 12:17 PM
Tgr moved this task from Inbox to Triaged on the Growth-Team board.May 21 2021, 1:14 PM
LGoto set the point value for this task to 2.Jun 2 2021, 4:50 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson renamed this task from Remove box-shadow usage in Popups, GettingStarted and GuidedTour to Remove box-shadow usage in Popups and GuidedTour.Jun 8 2021, 9:00 PM
Jdlrobson removed a project: MediaWiki-extensions-GettingStarted.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a parent task: T282045: [GOAL] Deprecate and remove skin code in preparation for 1.37.Jun 11 2021, 9:03 PM
bwang subscribed.Jun 18 2021, 3:44 PM

I also see an instance of the mixin in ULS, should that be added to this task?
https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelector/blob/master/resources/css/ext.uls-vector.less#L8

bwang claimed this task.Jun 18 2021, 3:54 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jun 18 2021, 4:29 PM

Change 700403 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/Popups@master] Remove obsolete box-shadow mixin

https://gerrit.wikimedia.org/r/700403

gerritbot added a project: Patch-For-Review.Jun 18 2021, 4:29 PM
bwang removed bwang as the assignee of this task.Jun 18 2021, 4:29 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jun 18 2021, 4:45 PM

Change 700403 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Remove obsolete box-shadow mixin

https://gerrit.wikimedia.org/r/700403

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 18 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 18 2021, 5:10 PM
bwang assigned this task to Edtadros.Jun 18 2021, 5:22 PM
bwang moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Edtadros reassigned this task from Edtadros to bwang.Jun 19 2021, 5:46 PM
Edtadros subscribed.

@bwang can you add some test steps and/or acceptance criteria please?

Volker_E added a comment.EditedJun 21 2021, 9:56 AM

@Edtadros and @bwang I think this should deliberately skip QA. It's a simple code change that should be verified by checking mentioned extensions for not using of .box-shadow LESS mixin after the change, but box-shadow: property. There's no risk here, if patch goes to code review and stylelint doesn't complain.

Volker_E added a comment.Jun 21 2021, 11:24 AM
In T282759#7163074, @bwang wrote:

I also see an instance of the mixin in ULS, should that be added to this task?
https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelector/blob/master/resources/css/ext.uls-vector.less#L8

That's Language team area. You could provide a patch, but let's keep this task for the ones Readers Web has to care about.

gerritbot added a comment.Jun 21 2021, 11:44 AM

Change 700532 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/GettingStarted@master] Remove obsolete LESS `box-shadow` mixin

https://gerrit.wikimedia.org/r/700532

gerritbot added a project: Patch-For-Review.Jun 21 2021, 11:44 AM
Volker_E added a comment.Jun 21 2021, 11:46 AM

Ha, and was misguided remembering GettingStarted and not GuidedTour. Pls ignore above.

gerritbot added a comment.Jun 21 2021, 11:47 AM

Change 700532 abandoned by VolkerE:

[mediawiki/extensions/GettingStarted@master] Remove obsolete LESS `box-shadow` mixin

Reason:

GettingStarted will be undeployed https://phabricator.wikimedia.org/T235752

https://gerrit.wikimedia.org/r/700532

gerritbot added a comment.Jun 21 2021, 12:05 PM

Change 700535 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/GuidedTour@master] Remove obsolete LESS `box-shadow` mixin

https://gerrit.wikimedia.org/r/700535

gerritbot added a comment.Jun 21 2021, 12:27 PM

Change 700535 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] Remove obsolete LESS `box-shadow` mixin

https://gerrit.wikimedia.org/r/700535

Restricted Repository Identity mentioned this in rEGTO6eabbadd0918: Remove obsolete LESS `box-shadow` mixin.Jun 21 2021, 12:35 PM
Volker_E removed bwang as the assignee of this task.Jun 21 2021, 12:47 PM
Volker_E moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Volker_E removed a project: Patch-For-Review.

Boldly moving to Signoff column.

LGoto assigned this task to Jdlrobson.Jun 21 2021, 5:13 PM
Jdlrobson closed this task as Resolved.Jun 21 2021, 6:07 PM

LGTM

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits