Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator

Make mention-success a `message` type notification
Closed, ResolvedPublic

Description

As noted on en.wiki, successful mention notifications would be better suited to the "blue" message -type echo notification, instead of the "red" alert -type.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 820825 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/Echo@master] extension.json: Make `mention-success` a `message` notification

https://gerrit.wikimedia.org/r/820825

Tagging User-notice as y'all may want to announce this change if and when it happens?

I prefer to follow whatever the community preference is here, although unfortunately it doesn't look like there's really any feedback currently.
But I agree that a blue notification likely makes more sense than an alert, so I don't have any objections.

@KStoller-WMF That link is pointing to a static revision from Aug 5. The actual thread had a few more comments, and is now archived. :-)
Personally (volunteer-hat), I think it's a good change.
As Tech News editor (re: User-notice) I'm not sure if this change would need an entry. It's a minor (but good!) improvement, but is unlikely to confuse anyone nor to cause other problems, so as with the hundreds of other changes that happen each week, I'd hesitantly suggest not highlighting it in Tech News.

@KStoller-WMF That link is pointing to a static revision from Aug 5. The actual thread had a few more comments, and is now archived. :-)
Personally (volunteer-hat), I think it's a good change.

Thanks! I agree, it seems like a good change.

I've +2'ed the change. I'll let User-notice folks decide whether it should be included or not.

Change 820825 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] extension.json: Make `mention-success` a `message` notification

https://gerrit.wikimedia.org/r/820825

I'll boldly remove the User-notice for now but if anyone strongly disagrees we can include it in a future TechNews edition. :)

Etonkovidova subscribed.

Checked on testwiki wmf.28 - mention-succes notification is of message type now, not an alert:

Screen Shot 2022-09-06 at 5.40.16 PM.png (844×1 px, 145 KB)