Following T317342: Investigate: Remove use of User::isBlockedGlobally and User::getGlobalBlock from Wikimedia deployed extensions, CheckUser should remove use of User::isBlockedGlobally
used here
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T231109 Remove Core coupling with GlobalBlocking extension | |||
| Open | None | T319069 Remove global-blocks-specific methods and hook from User class | |||
| Open | Spike | None | T315644 Global blocks should be treated as a subtype of blocks | ||
| Resolved | Cyndymediawiksim | T317337 Deprecate global-blocks-specific methods and hook | |||
| Resolved | • TThoabala | T317342 Investigate: Remove use of User::isBlockedGlobally and User::getGlobalBlock from Wikimedia deployed extensions | |||
| Resolved | Dreamy_Jazz | T318877 Remove use of User::isBlockedGlobally in CheckUser |
Event Timeline
Comment Actions
From the above I think the replacement should be that CheckUser depend on the GlobalBlocking extension and use methods from it, as I'm not sure if the CompositeBlock is what we need here.
Comment Actions
Change 837108 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Use GlobalBlocking::getUserBlock over User::isGloballyBlocked
Comment Actions
Change 837111 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[integration/config@master] Add GlobalBlocking as a phan dependency
Comment Actions
Change 837111 merged by jenkins-bot:
[integration/config@master] Add CheckUser as phan dependency for GlobalBlocking
Comment Actions
Change 841474 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):
[mediawiki/extensions/FileImporter@master] Use GlobalBlocking::getUserBlock instead of User::isGloballyBlocked
Comment Actions
Change 837108 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Use GlobalBlocking::getUserBlock over User::isGloballyBlocked
Comment Actions
@TThoabala After doing a GB on the IP address listed below, we were still able to do a CheckUser from the IP address that was blocked.
GB Details used in Local
Username: Testuserone
IP: 172.19.0.1
Time Length: 10 minutes
Start GB: 16:15, 13 October 2022
Expiry GB: 16:25, 13 October 2022
Reason: testing
GB did not block- Fail
Comment Actions
@GMikesell-WMF the patch for this task did affect any code in Special:Investigate, so if this is an issue it's been caused by something else. Plus the global block check replaced here is not performed on the checkuser attempting to run a check and instead on the IPs listed in Special:CheckUser. The testing method should be as follows:
- Make an edit while logged out
- Globally block the IP used to make that logged out edit
- Open Special:CheckUser
- Set the target as the IP you globally blocked and select 'Get edits'
- Run the check
- Observe that the edit the IP made has "(Globally blocked)" listed
Comment Actions
@Dreamy_Jazz Thanks for the testing steps! I did come across an interesting internal error while running those steps as seen in the screenshot. @TThoabala I replicated the steps from above and when I clicked on Check, I received the error below.
GB Details used in Local
Username: Testuserone
IP: 172.19.0.1
Time Length: 20 minutes
Start GB: 18:18, 14 October 2022
Expire GB on: 18:38, 14 October 2022
Reason: testing
Comment Actions
@TThoabala does that need to be a subtask? The usage has global blocks specified separately so unless the currently method does not work there is no need for this task to the global blocks to be a part of the composite block. I'll have a look at what might be causing the error, but I presume when testing you had the global block extension installed and loaded?
Comment Actions
@Tchanders no we did not, we had time scheduled for today, unfortunately @GMikesell-WMF had an emergency today.
@Dreamy_Jazz I realise this was a mistake it applies to other extensions not CheckUser(I will remove that ticket as parent task to this one), please note that I am not getting the error listed above. I had scheduled time with @GMikesell-WMF today to check his local set up and try to find what might be causing and error, but he unfortunately had a family emergency to attend to.
Comment Actions
Ah. Hopefully it's not serious. It doesn't seem to have caused errors on WMF wikis so it should be fine.
Comment Actions
@Dreamy_Jazz Thanks for the testing steps! I did come across an interesting internal error while running those steps as seen in the screenshot. @TThoabala I replicated the steps from above and when I clicked on Check, I received the error below.
GB Details used in Local
Username: Testuserone
IP: 172.19.0.1
Time Length: 20 minutes
Start GB: 18:18, 14 October 2022
Expire GB on: 18:38, 14 October 2022
Reason: testing
We figured out that this was a problem with the local environment. @GMikesell-WMF Should we move this task on now that's solved?
Comment Actions
After talking with @TThoabala about the issue being resolved as seen in the screenshot, I will move this task to Done. Thanks everyone!
