Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator

(Globally) blocked IP address has no permission to access "Translations" namespace (NS1198)
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • (This site should have translate extension installed)
  • Have an IP address blocked locally and globally
  • Access a random page in translations namespace from incognito mode

What happens?:
User get a permission error notice:

(permissionserrorstext-withaction: 1, (action-read))

(
(blockedtext: <a href="/wiki/User:Sotiale" title="User:Sotiale">‪Sotiale‬</a>, <a href="https://meta.wikimedia.org/wiki/NOP" class="extiw" title="m:NOP">Open proxy/Webhost</a>: See the <a href="https://meta.wikimedia.org/wiki/WM:OP/H" class="extiw" title="m:WM:OP/H">help page</a> if you are affected: , [redacted], ‪Sotiale‬, [redacted], [redacted], [redacted], [redacted])

)

What should have happened instead?:
There should be nothing happened.

Other information (browser name/version, screenshots, etc.):
Tested on metawiki
Above result happens on a situation where an IP range is globally AND locally blocked.
Only happened if trying to access NS1198, "Translations" namespace

image.png (1×2 px, 569 KB)

Event Timeline

Stang renamed this task from (Globally) blocked user has no permission to access "Translations" namespace (NS1198) to (Globally) blocked IP address has no permission to access "Translations" namespace (NS1198).Oct 12 2022, 10:24 AM
Stang updated the task description. (Show Details)
abi_ triaged this task as High priority.
abi_ subscribed.

This appears to have broken due to changes made for: T317594

Change 841933 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Message handle permission: Avoid performing checks if action is read

https://gerrit.wikimedia.org/r/841933

Change 841933 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Message handle permission: Avoid performing checks if action is read

https://gerrit.wikimedia.org/r/841933

Yeah, I could view pages under Translations namespace now, but when I clicked "Edit" tab, the error message throwed are still plain text (like the screenshot in the description of this task). Could this also be fixed? Thanks.

image.png (573×2 px, 277 KB)

Change 850410 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Translation permission: Return message key and params

https://gerrit.wikimedia.org/r/850410

Thanks for pointing this out again. I missed it and concentrated on fixing the read permission issue. Here's a screenshot from my local machine with this issue addressed:

image.png (337×1 px, 47 KB)

Change 850410 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Translation permission: Return message key and params

https://gerrit.wikimedia.org/r/850410

This fix for this went out with MW-1.40-notes (1.40.0-wmf.8; 2022-10-31) and I tested this on Test Wikipedia

Translations are visible:

image.png (466×985 px, 37 KB)

Editing translations:

image.png (666×1 px, 83 KB)

image.png (714×1 px, 81 KB)