Maniphest T320663

Special:Contribute shows an unknown message <special-tab-beiträge-short>
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Raymond
	Oct 12 2022, 4:41 PM

Description

Steps to replicate the issue (include links if applicable):

Activate Vector2022 skin
Go to https://de.wikipedia.org/wiki/Spezial:Contribute

What happens?:

Unknown message key <special-tab-beiträge-short> is shown.

"beiträge" is the German word for "contributions". I have no clue how this can happen, i.e. on https://fr.wikipedia.org/wiki/Sp%C3%A9cial:Contribute it is OK.

qa steps

Confirm the tabs are translated correctly in various languages on beta cluster:

https://de.m.wikipedia.beta.wmflabs.org/wiki/Spezial:Contribute?uselang=de
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contribute?uselang=fr

Skip QA in production

sign off steps

This patch requires follow up work as discussed here - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/841972/8/includes/specials/SpecialContribute.php#94 - make sure a patch or task exists for fixing that.

QA Results - Beta

AC	Status	Details
1	✅	T320663#8340200

Details

	Subject	Repo	Branch	Lines +/-
	Special:Contribute: Use canonical special page name for message keys	mediawiki/core	master	+6 -14

Customize query in gerrit

Event Timeline

Raymond created this task.Oct 12 2022, 4:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2022, 4:41 PM

It's a concatenation of the localized name of the "contributions" special page. On French Wikipedia the special page is just called "contributions" and the message exists so the message is displayed. Another example of this bug is on Spanish Wikipedia where the localized contributions page is called "Contribuciones" and Special:Contribute shows message key "special-tab-contribuciones-short". It should probably concatenate the English name of the special page rather than the localized name?

@Mabualruz Should probably be using the canonical special page key.

• Mabualruz claimed this task.Oct 12 2022, 7:48 PM

• Mabualruz moved this task from Needs Analysis to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.

Change 841972 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] Special:Contribute shows an unknown message <special-tab-beiträge-short>

https://gerrit.wikimedia.org/r/841972

gerritbot added a project: Patch-For-Review.Oct 12 2022, 8:12 PM

• Mabualruz reassigned this task from • Mabualruz to Jdlrobson.Oct 12 2022, 8:14 PM

• Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.

Change 841972 merged by jenkins-bot:

[mediawiki/core@master] Special:Contribute: Use canonical special page name for message keys

https://gerrit.wikimedia.org/r/841972

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.6; 2022-10-17).Oct 15 2022, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 15 2022, 1:30 AM

ovasileva triaged this task as High priority.Oct 17 2022, 2:47 PM

Jdlrobson lowered the priority of this task from High to Low.Oct 17 2022, 5:14 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.Oct 17 2022, 6:46 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Oct 17 2022, 9:58 PM

Jdlrobson moved this task from QA to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.

LGoto set the point value for this task to 1.Oct 20 2022, 5:02 PM

Jdlrobson moved this task from QA to Blocked on Others on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.Oct 20 2022, 5:11 PM

LGoto reassigned this task from Edtadros to Jdlrobson.Oct 20 2022, 5:20 PM

LGoto added a subscriber: Edtadros.

@Edtadros let's QA this on beta cluster only.

Pginer-WMF moved this task from Backlog to Entry points on the SectionTranslation board.Oct 24 2022, 10:51 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Confirm the tabs are translated correctly in various languages on beta cluster:

https://de.m.wikipedia.beta.wmflabs.org/wiki/Spezial:Contribute?uselang=de

Screen Shot 2022-10-24 at 3.11.02 PM.png (538×1 px, 63 KB)

https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contribute?uselang=fr

Screen Shot 2022-10-24 at 3.11.21 PM.png (531×1 px, 66 KB)

Edtadros updated the task description. (Show Details)Oct 24 2022, 10:13 PM

ovasileva closed this task as Resolved.Oct 26 2022, 9:42 AM

	F35622731: Screen Shot 2022-10-24 at 3.11.21 PM.png
	Oct 24 2022, 10:13 PM

	F35622728: Screen Shot 2022-10-24 at 3.11.02 PM.png
	Oct 24 2022, 10:13 PM

Special:Contribute shows an unknown message <special-tab-beiträge-short>Closed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions