IP Masking will affect lots of our products, features, tools, gadgets, etc. This task is for tracking work to update those that are owned by Content-Transform-Team, ahead of IP Masking being enabled on WMF sites.
See T326816: [Epic] Update features for temporary accounts, particularly What will be affected.
A preliminary investigation (T326759) has found that the following may be affected:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Restricted Task | |||||
| Resolved | kostajh | T294511 2021 Security Team wikireplicas audit | |||
| Declined | None | T284948 Raw IPs of logged-out users disclosed in wiki-replicas | |||
| In Progress | Niharika | T324492 Temporary accounts - MVP | |||
| Open | None | T326816 [Epic] Update features for temporary accounts | |||
| Open | None | T326874 Update Content Transform Team-owned products that may be affected by IP Masking | |||
| Open | cscott | T329457 IP Masking Considerations: services/parsoid |
The usage in Parsoid, according to the list of problematic methods in T326759, is limited to a single line:
$ git grep IPUtils src/Utils/Title.php:use Wikimedia\IPUtils; src/Utils/Title.php: $title = IPUtils::sanitizeIP( $title );
This is in the implementation of Title::newFromText(), which is a more-or-less direction port from Title::newFromText in core (although it was first ported to JavaScript and then reverse ported back to PHP). We should be able to just copy the "fixed" implementation of Title::newFromText() from core and then resolve this task.
There's another usage in core's includes/parser/Parsoid:
$ git grep getName\( includes/parser/Parsoid includes/parser/Parsoid/Config/PageConfig.php: return $user ? $user->getName() : null;
This appears to be inside PageConfig::getRevisionUser() which is never actually called inside Parsoid (!).