Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator

Update InlineMessage component in Codex
Open, Needs TriagePublic

Description

Background

  • Description: InlineMessage is now quite prominent. We could redesign its icon and text to be more subtle.
  • History: previous discussions about InlineMessage in T309239
  • Considerations: list any known challenges or blockers, or any other important information
  • Known use case(s):
Captura de Pantalla 2023-03-09 a las 13.58.11.png (1×868 px, 396 KB)
In Field component T309239 we've decided that InlineMessage (validation message) will be displayed below the Helper text. Since helper text is more subtle, InlineMessage text and icon seem too prominent

User stories

add at least one user story

Previous implementations

  • Codex demo: InlineMessage implemented as property in Message component.
  • Design style guide: add link, if applicable
  • OOUI: InlineMessage implementation in the OOUI demo
  • Vue: add link, if applicable

Design proposal

Option 1:

  • Bold message with base text size
  • Reduce the icon from 20px to 16px

Option 2:

  • Regular message with base text size
  • Reduce the icon from 20px to 16px

In both cases, the proposal is to use #AC6600 for Warning message since error and success use the feedback color in the message. We will need to create a new content color token in this case.

Captura de Pantalla 2023-03-09 a las 14.04.11.png (1×2 px, 866 KB)

Design spec

Once a component spec sheet has been created in Figma, remove the note stating that the spec is missing and link to the spec below.

Component spec sheet

Open questions

  • Should InlineMessage (validation message) be implemented as a separate component from Message component?

Acceptance criteria (or Done)

Design

  • Design the Figma spec sheet and add it in this task
  • Update the component in the Figma library. This step will be done by a DST member.

Code

  • Implement the component in Codex

Event Timeline

[#wmdj]: @bmartinezcalvo i have updated the necessary changes in my own copy of figma codex . dont know if any more action is required from my own end to completed this task?

Dolphyb claimed this task.
Dolphyb subscribed.
El T331623#10402134, @Dolphyb escribió:

[#wmdj]: @bmartinezcalvo i have updated the necessary changes in my own copy of figma codex . dont know if any more action is required from my own end to completed this task?

Hi @Dolphyb, thank you for working on this! As commented during the Codex Intro, we only include the components in the Codex library once they have been implemented in code, so we usually use Figma exploration files ]] to explore and decide before implementing the component, and then we include those updates in the Codex library once they have been implemented. So I recommend you to include your explorations in the Figma file linked in this task, so we can easily review it and discuss.

Regarding the new design of Inline Message, the idea with this task is to make the Inline Message less prominent since now the Bold style makes it so visible when used within forms. So you can explore possible solutions for that.

El T331623#10402134, @Dolphyb escribió:

[#wmdj]: @bmartinezcalvo i have updated the necessary changes in my own copy of figma codex . dont know if any more action is required from my own end to completed this task?

Hi @Dolphyb, thank you for working on this! As commented during the Codex Intro, we only include the components in the Codex library once they have been implemented in code, so we usually use Figma exploration files ]] to explore and decide before implementing the component, and then we include those updates in the Codex library once they have been implemented. So I recommend you to include your explorations in the Figma file linked in this task, so we can easily review it and discuss.

Regarding the new design of Inline Message, the idea with this task is to make the Inline Message less prominent since now the Bold style makes it so visible when used within forms. So you can explore possible solutions for that.

NOTE: As commented yesterday during the Design Jam opening session, we should not assign designers to the Phabricator tasks now. Instead, we should use the spreadsheet "Assigned to" column. So removing your assigned from this Phab task for now.

@bmartinezcalvo My bad that i didn't finish this task during WMDJ but i would still like to finish to task if it's okay by you?

El T331623#10406396, @Dolphyb escribió:

@bmartinezcalvo My bad that i didn't finish this task during WMDJ but i would still like to finish to task if it's okay by you?

@Dolphyb thank you for working on this. Yes, you can continue exploring this after the WMDJ. Just follow the steps documented in the Redesigning existing components guidelines. Feel free to reach out with any questions or to share your exploration here.