Maniphest T381358

"this.view is null" when saving an edit with CodeMirror 6
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Nardog
	Dec 3 2024, 2:03 AM

Tags

Referenced Files

None

Subscribers

Description

Steps to replicate the issue (include links if applicable):

Enable CM6 in beta features
Start editing a page
Turn syntax highlighting on
Modify the source
Click "Publish changes"

What happens?:
Console error "Uncaught TypeError: this.view is null" at codemirror.js:466.

What should have happened instead?:
No errors.

Details

	Subject	Repo	Branch	Lines +/-
	CodeMirror: fix toggle-related issues	mediawiki/extensions/CodeMirror	master	+137 -17

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open	Feature	None	T166098 Syntax sensitive and highlighting source code editor for template code wanted
		Resolved	Feature	Bhsd	T95100 Add autocompletion to CodeMirror extension
		Resolved	Feature	MusikAnimal	T181677 Implement syntax highlight for U+00A0 (no-break space, nbsp)
		Resolved	Feature	MusikAnimal	T301615 Show syntax highlighting on View Source/protected pages
		Resolved		MusikAnimal	T214989 Allow CodeMirror to be used for other textareas with WikiEditor
		In Progress	Goal	None	T259059 Upgrade to CodeMirror 6
		Resolved	BUG REPORT	Bhsd	T381358 "this.view is null" when saving an edit with CodeMirror 6

Event Timeline

Nardog created this task.Dec 3 2024, 2:03 AM

Restricted Application added a project: Community-Tech. · View Herald TranscriptDec 3 2024, 2:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Nardog added a parent task: T259059: Upgrade to CodeMirror 6.Dec 3 2024, 2:07 AM

Bhsd moved this task from Backlog to Bugs on the MediaWiki-extensions-CodeMirror board.Dec 3 2024, 8:03 AM

Change #1100045 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] CodeMirror: fix toggle-related issues

https://gerrit.wikimedia.org/r/1100045

gerritbot added a project: Patch-For-Review.Dec 3 2024, 8:49 AM

Bhsd claimed this task.Dec 4 2024, 5:29 AM

Change #1100045 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirror: fix toggle-related issues

https://gerrit.wikimedia.org/r/1100045

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2024, 10:30 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Dec 9 2024, 11:00 PM

@Nardog Before publishing changes, did you turn off syntax highlighting?

No, but either way I get the same error.

I am unable to reproduce the bug if syntax highlighting is not toggled off when publishing changes.

Hmm, I can't reproduce it without turning it off either anymore.

Bhsd closed this task as Resolved.Sat, Dec 21, 4:32 PM

Bhsd moved this task from Bugs to Done on the MediaWiki-extensions-CodeMirror board.