Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Page MenuHomePhabricator
Create Task
Maniphest T38294

It should be possible to hide the heading on the main page without hiding the heading on its associated diff page
Closed, ResolvedPublic
Actions

Assigned To
Jdlrobson
Authored By
• bzimport
Apr 27 2012, 8:49 AM
Tags
Referenced Files
F34909516: Screen Shot 2022-01-06 at 9.49.53 AM.png
Jan 6 2022, 5:50 PM
Subscribers
alistair3149
Ammarpad
ashley
Jdlrobson
Lens0021
MarkAHershberger
matmarex
View All 9 Subscribers
Tokens
"Piece of Eight" token, awarded by Volker_E.

Description

Author: vlakoff

Description:
<body> tag has the same class attributes for "normal view" and "diff", for example:

http://en.wikipedia.org/wiki/Foobar
and
http://en.wikipedia.org/w/index.php?title=Foobar&diff=prev&oldid=482777894

It would be very useful for CSS styling to be able to distinguish these pages through <body> classes

QA

Details

Reference
bz36294
SubjectRepoBranchLines +/-
Hiding main page heading should not hide title on diff/history viewsmediawiki/coremaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:27 AM
• bzimport added a project: MediaWiki-User-Interface.
• bzimport set Reference to bz36294.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Apr 27 2012, 8:49 AM
Krinkle added a comment.Apr 27 2012, 10:07 AM

The <body> contains action- prefixed class names (e.g. action-view, action-history, action-edit etc.). However "diff' is not an action, but a component of the view action.

It is not a different page action or layout, it therefor doesn't make sense to style the entire page differently just because it contains a diff component.

The diff component itself can be styled by using the css hooks of the diff component:

  • table.diff
  • .diff-marker
  • .diff-content
  • .diff-otitle
  • .diff-ntitle
  • .diff-lineno
  • .diff-deletedline
  • etc. (See also ./resources/mediawiki.action/mediawiki.action.history.diff.css)

If you need a selector for the entire page, could you elaborate on a use case?

• bzimport added a comment.Apr 27 2012, 10:13 AM

vlakoff wrote:

On the French wiki homepage, we hide the H1:

http://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal

However, the H1 is also hidden on this page's diffs:

http://fr.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Accueil_principal&diff=75110565&oldid=prev

For consistency, it would be great to hide the H1 only on the viewed page, and nowhere else.

Note that the issue also concerns the English wiki

Krinkle unsubscribed.Apr 25 2017, 10:11 PM
Jdlrobson renamed this task from views and diffs should be distinguishable for CSS to It should be possible to hide the heading on the main page without hiding the heading on its associated diff page.Jan 13 2021, 7:41 PM
Jdlrobson added a project: MediaWiki-Core-Skin-Architecture.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: patch-welcome, good first task.
Jdlrobson subscribed.

Seems reasonable and use case is clear. Can be done inside OutputPage::headElement
A class action-view-diff should be added to such pages. Will happily review patch.

Jdlrobson moved this task from Backlog to Skinning system on the MediaWiki-User-Interface board.Jan 13 2021, 7:43 PM
Jdlrobson moved this task from Backlog to Phase 3 - standardise template data on the MediaWiki-Core-Skin-Architecture board.Jan 15 2021, 11:34 PM
Jdlrobson moved this task from Phase 3 - standardise template data to It's complicated on the MediaWiki-Core-Skin-Architecture board.Feb 26 2021, 3:32 AM
alistair3149 subscribed.May 20 2021, 6:10 AM
Jdlrobson moved this task from It's complicated to Small HTML modifications to support our users better on the MediaWiki-Core-Skin-Architecture board.Jul 23 2021, 12:18 AM
Lens0021 subscribed.Dec 22 2021, 11:07 AM
Ammarpad subscribed.Dec 22 2021, 7:35 PM

The heading is also not shown on history page, which does not look good too. Relatedly, there should be api (perhaps in OutputPage or WebReqeuest) to easily and centrally tell whether we're currently in diff view

ashley subscribed.Dec 22 2021, 7:56 PM
In T38294#7586384, @Ammarpad wrote:

The heading is also not shown on history page, which does not look good too. Relatedly, there should be api (perhaps in OutputPage or WebReqeuest) to easily and centrally tell whether we're currently in diff view

Curious how, for the purposes of the <body> CSS class action-<action name> diff pages count as view, which is technically sorta correct but very unintuitive and in the case of the fr.wikipedia pages mentioned in the task description, it does mean it's not possible to distinguish in CSS whether we're truly viewing the page or whether we're viewing a diff.
Not sure what the best way forward here would be; I'm tempted to suggest that diff views should identify themselves as action-diff because it makes logical sense, except diffs aren't an action, they're "just" action=view with a diff param tacked into the whole query string. Tricky! :-/

gerritbot added a comment.Dec 22 2021, 9:31 PM

Change 749580 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Hiding main page heading should not hide title on diff/history views

https://gerrit.wikimedia.org/r/749580

gerritbot added a project: Patch-For-Review.Dec 22 2021, 9:31 PM
Jdlrobson added a comment.EditedDec 22 2021, 9:32 PM

This should be fixed by T297019 as it will remove the need for adding CSS to hide the main page title in MediaWiki:Common.css
I did forget to check that action === view in that task, so this follow up is needed: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/749580

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2021-22).Dec 22 2021, 9:36 PM
Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
matmarex subscribed.Dec 23 2021, 8:59 PM
gerritbot added a comment.Dec 24 2021, 12:43 AM

Change 749580 merged by jenkins-bot:

[mediawiki/core@master] Hiding main page heading should not hide title on diff/history views

https://gerrit.wikimedia.org/r/749580

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 24 2021, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 24 2021, 1:10 AM
Jdlrobson claimed this task.Dec 24 2021, 2:28 AM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Volker_E subscribed.Jan 3 2022, 5:48 PM
Volker_E awarded a token.Jan 3 2022, 5:52 PM
Jdlrobson closed this task as Resolved.Jan 6 2022, 5:50 PM
Jdlrobson mentioned this in T298715: Interface editors: Can change the heading on the main page.

I tried this change out on Italian Wikipedia and it resolved the bug (heading now present):
https://it.wikipedia.org/w/index.php?title=Pagina_principale&type=revision&diff=122948985&oldid=122947071

Screen Shot 2022-01-06 at 9.49.53 AM.png (1×2 px, 399 KB)

I've communicated this out to communities T298715

Jdlrobson mentioned this in T350596: Question: Should it be possible to load mediawiki.diff.styles on non-diff pages?.Nov 13 2023, 9:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits