OOjs and OOjs-UI should be made available as a library in core, much like jQuery.
Version: unspecified
Severity: enhancement
Description
Description
Details
Details
- Reference
- bz56572
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T59943 Generate the GettingStarted dialogs from OOUI | |||
| Resolved | None | T58573 Code quality: Use oo.js and related utilities to make the code a lot simpler | |||
| Resolved | • TrevorParscal | T58572 Make oojs and oojs-ui libraries available in MediaWiki core | |||
| Resolved | • Catrope | T58571 Move OOjs and OOjs-UI to their own repos |
Event Timeline
Comment Actions
Change 98887 had a related patch set uploaded by Catrope:
Add oojs and oojs-ui to core
Comment Actions
Change 98887 had a related patch set uploaded by Jforrester:
Add oojs and oojs-ui to core
Comment Actions
OOJS (not included the UI part) was added in https://gerrit.wikimedia.org/r/#/c/99305/ (which is merged).
Comment Actions
Change 98887 had a related patch set uploaded by Jforrester:
Add OOJS UI v0.1.0-pre (f90c7bcce6) to core
Comment Actions
Change 98887 had a related patch set uploaded by Siebrand:
Add OOJS UI v0.1.0-pre (rGOJUda9ec955a896) to core
Comment Actions
Can we please use submodules in mediawiki/core.git that would point to OOUI / OOJS tags. I really hate the proposal of copy/pasting code there.
If we want to ship them on Wikimedia cluster, we can still use submodules like we are doing in wmf branches with extensions.
To ship OOUI / OOJS with MediaWiki tarball, the make-release script we are using can be made to proceed submodules and thus include the content in the .tar.gz.
Comment Actions
(In reply to comment #6)
Can we please use submodules in mediawiki/core.git that would point to OOUI /
OOJS tags. I really hate the proposal of copy/pasting code there.If we want to ship them on Wikimedia cluster, we can still use submodules
like we are doing in wmf branches with extensions.To ship OOUI / OOJS with MediaWiki tarball, the make-release script we are
using can be made to proceed submodules and thus include the content in the
.tar.gz.
We've historically avoided submodules in MW core because they add complications for down-stream users of git.
Also, note in this case that these aren't just "copy-and-pasted" OOjs / OOjs-UI trees, but are built, bundled libraries via a grunt process.
Comment Actions
We've historically avoided submodules in MW core because they add
complications
for down-stream users of git.Also, note in this case that these aren't just "copy-and-pasted" OOjs /
OOjs-UI
trees, but are built, bundled libraries via a grunt process.
Fair enough. I have removed my -2 from the Gerrit change :-]