PYTHON-5387 Better test assertions for membership #2348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleepyStick
commented
May 22, 2025
| @@ -933,16 +933,19 @@ async def test_clone(self): | |||
| # Shallow copies can so can mutate | |||
| cursor2 = copy.copy(cursor) | |||
| cursor2._projection["cursor2"] = False | |||
| self.assertTrue(cursor._projection and "cursor2" in cursor._projection) | |||
| self.assertIsNotNone(cursor._projection) | |||
There was a problem hiding this comment.
in the spirit of better test assertions, I broke it up into two assertions..(and assumed the first cursor._projection was to check that it is not None) if that's an incorrect assumption, or we prefer the original way, I'm happy to change these back to the original (or something else)
NoahStapp
previously approved these changes
May 22, 2025
blink1073
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR for PYTHON-5262, this one is for
in:self.assertTrue(... in ...)->self.assertIn(..., ...)self.assertTrue(... not in ...)->self.assertNotIn(..., ...)self.assertFalse(... in ...)->self.assertNotIn(..., ...)