-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/ocb): implement providers support #31754
base: main
Are you sure you want to change the base?
Conversation
can anyone help me , i cant figure out where i am failing |
You need have PR title which follows conventional commit conventions Also I see no documentation changes or unit tests as your choices in the form PR template forms suggest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert all these changes.
Only changes in lib/modules/manager/ocb
are necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just made the changes in , extract.ts and schema.ts , but how come these many changes have been made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably worked on wrong base branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests to cover the providers too.
@@ -52,7 +52,7 @@ export function extractPackageFile( | |||
deps.push(...processModule(definition.extensions, 'extensions')); | |||
deps.push(...processModule(definition.processors, 'processors')); | |||
deps.push(...processModule(definition.receivers, 'receivers')); | |||
|
|||
deps.push(...processModule(definition.providers,'providers')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deps.push(...processModule(definition.providers,'providers')); | |
deps.push(...processModule(definition.providers,'providers')); | |
@secustor wondering if there is a TTL on unworked PRs? 💭 |
There are no TTL, this PR needs fixes implement and a new review requested. See the code of conduct |
Changes
Context
closes #31747
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: