feat(trusted-domain): add frontend management (without ui) #10337

AMoreaux · 2025-02-19T16:44:44Z

No description provided.

Introduce functionality for managing trusted email domains in workspace settings. Includes UI components, validation schemas, GraphQL mutations, and queries to support adding, viewing, and deleting trusted domains. Also updates dependencies and adjusts existing components for better integration.

…sted-domains # Conflicts: # packages/twenty-server/src/engine/core-modules/workspace-trusted-domain/dtos/send-trusted-domain-verification-email.input.ts # packages/twenty-server/src/engine/core-modules/workspace-trusted-domain/workspace-trusted-domain.resolver.ts

Removed the concept of trusted domain email verification, streamlining the process for managing trusted domains. Adjusted the corresponding UI, server-side logic, and GraphQL types to reflect the updated approach, reducing complexity and unused functionality.

…sted-domains

Changed the delete method to use trustedDomain.id instead of the entire trustedDomain object. This ensures the correct data is passed to the repository and avoids potential errors.

…sted-domains

Introduce a hook to validate trusted domains using a validation token. This sets up the foundation for handling domain validation in the security settings module.

…sted-domains

Introduced a mutation to validate trusted domains using Apollo Client and removed the previous hook-based implementation. Added a new component to handle validation side effects and integrated it into the trusted domains list. This enhances reliability and provides user feedback for validation success or failure.

…sted-domains

…sted-domains # Conflicts: # packages/twenty-front/src/generated/graphql.tsx

Introduce mutations and queries to create, delete, and validate Workspace Trusted Domains. This includes input types, output types, and Apollo hooks for managing trusted domains in the workspace context.

…sted-domains

greptile-apps

PR Summary

This PR adds frontend management for trusted domains in the workspace security settings. Here's a concise summary of the key changes:

Added new GraphQL mutations and queries for managing trusted domains (create, delete, validate, fetch) with proper TypeScript types and Apollo Client hooks
Implemented domain validation schema using Zod with RFC-compliant regex for domain names and proper error messages
Created new components for trusted domain management including list view, validation effects, and dropdown menus under the security settings
Added new routes in SettingsRoutes.tsx for trusted domain management (new/edit) with lazy loading
Integrated trusted domain management UI into the security settings page alongside existing SSO and authentication options

Key points to review:

Mutation name mismatch between frontend (CreateWorkspaceTrustDomain) and backend (createWorkspaceTrustedDomain) needs to be fixed
Consider adding loading states and better error handling in trusted domain components
Verify validation token security measures in the domain validation flow
Review state management approach using Recoil for trusted domains list
Ensure proper cleanup of URL parameters after domain validation

_{28 file(s) reviewed, 20 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-02-19T16:46:42Z

packages/twenty-front/src/modules/app/components/SettingsRoutes.tsx

+      <Route
+        path={SettingsPath.EditTrustedDomain}
+        element={<SettingsSecurityTrustedDomain />}
+      />
+      <Route
+        path={SettingsPath.NewTrustedDomain}
+        element={<SettingsSecurityTrustedDomain />}
+      />


style: Consider adding a SettingsProtectedRouteWrapper for trusted domain routes to ensure proper access control, similar to other sensitive settings routes

greptile-apps · 2025-02-19T16:51:16Z

...twenty-front/src/modules/settings/security/graphql/mutations/createWorkspaceTrustedDomain.ts

+import { gql } from '@apollo/client';
+
+export const CREATE_WORKSPACE_TRUSTED_DOMAIN = gql`
+  mutation CreateWorkspaceTrustDomain($input: CreateTrustedDomainInput!) {


syntax: Mutation name 'CreateWorkspaceTrustDomain' should be 'CreateWorkspaceTrustedDomain' to match the resolver name

Suggested change

mutation CreateWorkspaceTrustDomain($input: CreateTrustedDomainInput!) {

mutation CreateWorkspaceTrustedDomain($input: CreateTrustedDomainInput!) {

greptile-apps · 2025-02-19T16:51:19Z

...ecurity/components/workspaceTrustedDomains/SettingsSecurityTrustedDomainValidationEffect.tsx

+        onError: () => {
+          enqueueSnackBar('Error validating trusted domain', {
+            variant: SnackBarVariant.Error,
+          });
+        },


style: error handler doesn't display the actual error message from the server, which could help users understand what went wrong

...security/components/workspaceTrustedDomains/SettingsSecurityTrustedDomainRowDropdownMenu.tsx

greptile-apps · 2025-02-19T16:51:42Z

...security/components/workspaceTrustedDomains/SettingsSecurityTrustedDomainRowDropdownMenu.tsx

+  const handleDeleteWorkspaceTrustedDomain = async () => {
+    const result = await deleteWorkspaceTrustDomain({
+      variables: {
+        input: {
+          id: workspaceTrustedDomain.id,
+        },
+      },
+      onCompleted: () => {
+        setWorkspaceTrustedDomains((workspaceTrustedDomains) => {
+          return workspaceTrustedDomains.filter(
+            (trustedDomain) => trustedDomain.id !== workspaceTrustedDomain.id,
+          );
+        });
+      },
+    });
+    if (isDefined(result.errors)) {
+      enqueueSnackBar('Error deleting workspace trust domain', {
+        variant: SnackBarVariant.Error,
+        duration: 2000,
+      });
+    }
+  };


logic: state update in onCompleted runs even if there are errors, and error handling only shows generic message without actual error details from result.errors

greptile-apps · 2025-02-19T16:56:19Z