Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

bump isort pre commit hook#228

Merged
petersalemink95 merged 1 commit intomainfrom
fix/bump-isort-precommit-hook
Apr 5, 2023
Merged

bump isort pre commit hook#228
petersalemink95 merged 1 commit intomainfrom
fix/bump-isort-precommit-hook

Conversation

@mgovers
Copy link
Member

@mgovers mgovers commented Apr 5, 2023

Enforce newer isort version that fixes compatibility with a backwards incompatible change in poetry (its packager).

Only new contributors that use pre-commit appear to be affected (due to caching of old poetry versions)

@mgovers
bump isort pre commit hook
e2fb167 
Signed-off-by: Martijn Govers <martygovers@hotmail.com>
@mgovers mgovers added the dependencies Pull requests that update a dependency file label Apr 5, 2023
@mgovers mgovers self-assigned this Apr 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgovers mgovers removed the request for review from TonyXiang8787 April 5, 2023 07:15
@petersalemink95 petersalemink95 merged commit a62c187 into main Apr 5, 2023
@petersalemink95 petersalemink95 deleted the fix/bump-isort-precommit-hook branch April 5, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersalemink95 petersalemink95 petersalemink95 approved these changes

Assignees

@mgovers mgovers

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgovers @petersalemink95