Fix poetry pip-shims extras dependency#2078
Merged
timothycrosley merged 1 commit intoPyCQA:mainfrom Jan 28, 2023
jooola:fix_poetry_validation
Merged
Fix poetry pip-shims extras dependency#2078timothycrosley merged 1 commit intoPyCQA:mainfrom jooola:fix_poetry_validation
timothycrosley merged 1 commit intoPyCQA:mainfrom
jooola:fix_poetry_validation
Conversation
With poetry-core>=1.5.0, the dependencies in extras must be present in the main dependency group.
|
Alright, who's got the pager? |
|
To prevent something like this from happening again, maybe isort's pyproject.toml should pin a specific version of poetry-core. |
timothycrosley
approved these changes
Jan 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2078 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 38 38
Lines 3091 3091
Branches 747 747
=======================================
Hits 3067 3067
Misses 14 14
Partials 10 10 |
7 tasks
hugovk
added a commit
to hugovk/em-keyboard
that referenced
this pull request
Jan 29, 2023
hugovk
added a commit
to hugovk/github-tools
that referenced
this pull request
Jan 29, 2023
hugovk
added a commit
to hugovk/gutenberg-metadata
that referenced
this pull request
Jan 29, 2023
Re: PyCQA/isort#2078 Committed via https://github.com/asottile/all-repos
hugovk
added a commit
to hugovk/hugovk
that referenced
this pull request
Jan 29, 2023
Re: PyCQA/isort#2078 Committed via https://github.com/asottile/all-repos
hugovk
added a commit
to hugovk/lastfm-tools
that referenced
this pull request
Jan 29, 2023
Re: PyCQA/isort#2078 Committed via https://github.com/asottile/all-repos
This was referenced Jan 29, 2023
4 tasks
7 tasks
4 tasks
This was referenced Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With poetry-core>=1.5.0, the dependencies in extras must be present in the main dependency group.
Fix #2077