RPP Box Filter on HOST #425
Open
+3,721
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
r-abishek
commented
Aug 10, 2024
•
- Updates version to RPP 1.9.4
- Adds tensor style box filter on HOST for kernel sizes 3/5/7/9 with U8/F16/F32/I8 bit depths
- NCHW/NHWC variants support
- Adds relevant unit/perf tests
Version Upgrade
…nx (#337) * Bump rocm-docs-core[api_reference] from 0.38.1 to 1.0.0 in /docs/sphinx Bumps [rocm-docs-core[api_reference]](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.38.1 to 1.0.0. - [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v0.38.1...v1.0.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Use Python 3.10 in RTD config --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sam Wu <sam.wu2@amd.com>
added PKD3 to PLN3 support
Box filter HOST TOT Merge
rrawther
reviewed
Oct 8, 2024
| srcPtrImage = srcPtr + batchCount * srcDescPtr->strides.nStride; | ||
| dstPtrImage = dstPtr + batchCount * dstDescPtr->strides.nStride; | ||
|
|
||
| Rpp32u padLength = kernelSize / 2; |
rrawther
reviewed
Oct 8, 2024
| @@ -64,7 +64,8 @@ int main(int argc, char **argv) | |||
| int decoderType = atoi(argv[13]); | |||
| int batchSize = atoi(argv[14]); | |||
|
|
|||
| bool additionalParamCase = (testCase == 8 || testCase == 21 || testCase == 23 || testCase == 24 || testCase == 79); | |||
| bool additionalParamCase = (testCase == 8 || testCase == 21 || testCase == 23 || testCase == 24 || testCase == 49 || testCase == 79); | |||
There was a problem hiding this comment.
we need to remove all these hardcoded testCase manipulation and use more standard coding methods like string or map table. I guess this should be done in a separate PR
rrawther
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
@r-abishek : can't verify the SSE/AVX code correctness. I am assuming the tests are comparing reference C++ implementation for correctness
|
@kiritigowda Can you please review this PR and merge if this is OK |
|
All Jenkins CI passing. Waiting on Azure - https://dev.azure.com/ROCm-CI/ROCm-CI/_build/results?buildId=10400&view=results |
rrawther
approved these changes
Oct 18, 2024
LakshmiKumar23
approved these changes
Oct 18, 2024
|
@rrawther @LakshmiKumar23 Mel-Filter Bank (#421) and Spectrogram (#433) to be ideally merged before Box Filter for correct versioning order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.