RPP Audio Support HIP - Spectrogram #433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
r-abishek
commented
Aug 22, 2024
•
- Updates version to RPP 1.9.3
- Adds RPP audio support for Spectrogram on HIP backend.
- Adds relevant qa tests and performance tests.
made changes to compute num_windows in executor instead of recomputing everytime inside kernel
combined processing of FT and TF layouts in single kernel
made changes to compute windowOutput stride from dstDescPtr
Spectrogram HIP TOT Merge
Spectrogram HIP TOT Merge
|
@r-abishek -- merge conflicts |
RPP Spectrogram HIP TOT Merge
AryanSalmanpour
requested changes
Sep 19, 2024
| // copy the hanning window values to hip memory | ||
| Rpp32f *d_windowFn = handle.GetInitHandle()->mem.mgpu.scratchBufferHip.floatmem; | ||
| CHECK_RETURN_STATUS(hipMemcpyAsync(d_windowFn, windowFn, windowLength * sizeof(Rpp32f), hipMemcpyHostToDevice, handle.GetStream())); | ||
| CHECK_RETURN_STATUS(hipStreamSynchronize(handle.GetStream())); |
There was a problem hiding this comment.
Please remove CHECK_RETURN_STATUS(hipStreamSynchronize(handle.GetStream()))); from here and line 198 and move it to after the last hipLaunchKernelGGL call.
…goes out of bounds in HOST kernel
Spectrogram HIP changes based on review comments
|
@AryanSalmanpour This PR addresses verbal comments from the code review now |
AryanSalmanpour
approved these changes
Sep 24, 2024
|
All Jenkins CI passing. Waiting on Azure - https://dev.azure.com/ROCm-CI/ROCm-CI/_build/results?buildId=10403&view=results |
…upport_6_spectrogram_hip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.