Update csslint library to avoid blank rules #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RUN npm install -g csslint && \ | ||
| apk --update add ruby ruby-dev ruby-bundler less ruby-nokogiri build-base && \ | ||
| RUN apk --update add nodejs git ruby ruby-dev ruby-bundler less ruby-nokogiri build-base && \ | ||
| npm install -g codeclimate/csslint.git#2a53712c61710840c023978418c7b48e3f32ac64 && \ |
There was a problem hiding this comment.
Where was the npm install happening before?
There was a problem hiding this comment.
It was originally on the first line of the RUN command. I had to move it to the second because it require git now.
There was a problem hiding this comment.
Bah, totally misread the diff.
|
LGTM |
gdiggs
added a commit
that referenced
this pull request
Jul 1, 2015
Update csslint library to avoid blank rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @codeclimate/review
Relevant CSSLint commits: