Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Update csslint library to avoid blank rules #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2015
Merged

Update csslint library to avoid blank rules #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ededfc
Update csslint library
gdiggs Jul 1, 2015
61a9250
Add circle.yml file
gdiggs Jul 1, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
FROM mhart/alpine-node
FROM alpine:edge

WORKDIR /usr/src/app
COPY Gemfile /usr/src/app/
COPY Gemfile.lock /usr/src/app/

RUN npm install -g csslint && \
apk --update add ruby ruby-dev ruby-bundler less ruby-nokogiri build-base && \
RUN apk --update add nodejs git ruby ruby-dev ruby-bundler less ruby-nokogiri build-base && \
npm install -g codeclimate/csslint.git#2a53712c61710840c023978418c7b48e3f32ac64 && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where was the npm install happening before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was originally on the first line of the RUN command. I had to move it to the second because it require git now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah, totally misread the diff.

bundle install -j 4 && \
apk del build-base && rm -fr /usr/share/ri

Expand Down
24 changes: 24 additions & 0 deletions circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
machine:
services:
- docker
environment:
CLOUDSDK_CORE_DISABLE_PROMPTS: 1
image_name: codeclimate-csslint

dependencies:
pre:
- echo $gcloud_json_key_base64 | sed 's/ //g' | base64 -d > /tmp/gcloud_key.json
- curl https://sdk.cloud.google.com | bash
- gcloud auth activate-service-account $gcloud_account_email --key-file /tmp/gcloud_key.json
- gcloud docker -a

test:
override:
- docker build -t=$registry_root/$image_name:b$CIRCLE_BUILD_NUM .

deployment:
registry:
branch: master
commands:
- docker push $registry_root/$image_name:b$CIRCLE_BUILD_NUM