Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

chore: clean up to_gbq testing and doc #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattyopl wants to merge 2 commits into from
+2 −3
Closed

chore: clean up to_gbq testing and doc #968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf75862
chore: clean up `to_gbq` testing and doc
Sep 9, 2024
a4e9697
Merge branch 'main' into dev2
mattyopl Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/system/small/test_dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4658,9 +4658,8 @@ def test_to_gbq_and_create_dataset(session, scalars_df_index, dataset_id_not_cre


def test_to_gbq_table_labels(scalars_df_index):
destination_table = "bigframes-dev.bigframes_tests_sys.table_labels"
result_table = scalars_df_index.to_gbq(
destination_table, labels={"test": "labels"}, if_exists="replace"
labels={"test": "labels"}, if_exists="replace"
)
client = scalars_df_index._session.bqclient
table = client.get_table(result_table)
Expand Down
2 changes: 1 addition & 1 deletion third_party/bigframes_vendored/pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ def to_gbq(
specified in `clustering_columns`.

labels (dict[str, str], default None):
Specifies table labels within BigQuery
Specifies table labels within BigQuery.

Returns:
str:
Expand Down