Suggest improved introduction to Style/#Idioms#243
Merged
kennethreitz merged 2 commits intorealpython:masterfrom Mar 4, 2013
adityaathalye:master
Merged
Suggest improved introduction to Style/#Idioms#243kennethreitz merged 2 commits intorealpython:masterfrom adityaathalye:master
kennethreitz merged 2 commits intorealpython:masterfrom
adityaathalye:master
Conversation
added 2 commits
January 30, 2013 02:10
Pulling in the latest changes at origin.
My reading, though limited, suggests that the general notion of Idioms is used often, but rarely explained. It feels very alien to beginners. A term like "Idiomatic Python" can cause mental stack overflow. It did to me :) So I humbly submit, in this case, explicit is better than implicit. I debated whether to place it at the top of the document, where idioms are first mentioned, but placed it here instead, as this section explicitly references the topic of idioms.
Contributor
Author
|
Hi, I'm wondering if this edit suggestion is lacking or if I did some newbie boo-boo... I'll appreciate any feedback. Thanks! |
kennethreitz
pushed a commit
that referenced
this pull request
Mar 4, 2013
Suggest improved introduction to Style/#Idioms
Contributor
|
thanks for this! |
Contributor
Author
|
Thanks, Kenneth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My reading, though limited, suggests that the general notion of Idioms
is used often, but rarely explained. It feels very alien to beginners. A
term like "Idiomatic Python" can cause mental stack overflow. It did to
me :)
So I humbly submit, in this case, explicit is better than implicit.
I debated whether to place it at the top of the document,
where idioms are first mentioned, but placed it here instead, as this
section explicitly references the topic of idioms.