Angular - Angular Coding Style Guide
Angular - Angular Coding Style Guide
Looking for an opinionated guide to Angular syntax, conventions, and application structure? Step right in! This style
guide presents preferred conventions and, as importantly, explains why.
Style vocabulary
Each guideline describes either a good or bad practice, and all have a consistent presentation.
The wording of each guideline indicates how strong the recommendation is.
Do is one that should always be followed. Always might be a bit too strong of a word. Guidelines that literally should
always be followed are extremely rare. On the other hand, you need a really unusual case for breaking a Do guideline.
Consider guidelines should generally be followed. If you fully understand the meaning behind the guideline and have
a good reason to deviate, then do so. Please strive to be consistent.
Avoid indicates something you should almost never do. Code examples to avoid have an unmistakable red header.
Some code examples display a file that has one or more similarly named companion files. For example,
hero.component.ts and hero.component.html .
The guideline uses the shortcut hero.component.ts|html|css|spec to represent those various files. Using this
shortcut makes this guide's file structures easier to read and more terse.
Single responsibility
Apply the single responsibility principle (SRP) to all components, services, and other symbols. This helps make
the app cleaner, easier to read and maintain, and more testable.
Rule of One
Style 01-01
Why? One component per file makes it far easier to read, maintain, and avoid collisions with teams in source control.
Why? One component per file avoids hidden bugs that often arise when combining components in a file where they
may share variables, create unwanted closures, or unwanted coupling with dependencies.
Why? A single component can be the default export for its file which facilitates lazy loading with the router.
The key is to make the code more reusable, easier to read, and less mistake prone.
The following negative example defines the AppComponent , bootstraps the app, defines the Hero model object, and
loads heroes from the server all in the same file. Don't do this.
/
app/heroes/hero.component.ts
/* avoid */
import { Component, NgModule, OnInit } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
interface Hero {
id: number;
name: string;
}
@Component({
selector: 'app-root',
template: `
<h1>{{title}}</h1>
<pre>{{heroes | json}}</pre>
`,
styleUrls: ['app/app.component.css']
})
class AppComponent implements OnInit {
title = 'Tour of Heroes';
ngOnInit() {
getHeroes().then(heroes => (this.heroes = heroes));
}
}
@NgModule({
imports: [BrowserModule],
declarations: [AppComponent],
exports: [AppComponent],
bootstrap: [AppComponent]
})
export class AppModule {}
platformBrowserDynamic().bootstrapModule(AppModule);
It is a better practice to redistribute the component and its supporting classes into their own, dedicated files.
platformBrowserDynamic().bootstrapModule(AppModule);
As the app grows, this rule becomes even more important. Back to top
Small functions
Style 01-02
Why? Small functions are easier to test, especially when they do one thing and serve one purpose.
Why? Small functions help avoid hidden bugs that come with large functions that share variables with external
scope, create unwanted closures, or unwanted coupling with dependencies.
Back to top
Naming
/
Naming conventions are hugely important to maintainability and readability. This guide recommends naming
conventions for the file name and the symbol name.
Do follow a pattern that describes the symbol's feature then its type. The recommended pattern is
feature.type.ts .
Why? Naming conventions help provide a consistent way to find content at a glance. Consistency within the project
is vital. Consistency with a team is important. Consistency across a company provides tremendous efficiency.
Why? The naming conventions should simply help find desired code faster and make it easier to understand.
Why? Names of folders and files should clearly convey their intent. For example, app/heroes/hero-
list.component.ts may contain a component that manages a list of heroes.
Back to top
Do use consistent type names for all components following a pattern that describes the component's feature then
its type. A recommended pattern is feature.type.ts .
Do use conventional type names including .service , .component , .pipe , .module , and .directive . Invent
additional type names if you must but take care not to create too many.
Why? Type names provide a consistent way to quickly identify what is in the file.
Why? Type names make it easy to find a specific file type using an editor or IDE's fuzzy search techniques.
Why? Unabbreviated type names such as .service are descriptive and unambiguous. Abbreviations such as .srv ,
.svc , and .serv can be confusing.
Why? Type names provide pattern matching for any automated tasks.
Back to top
Do use consistent names for all assets named after what they represent.
Do append the symbol name with the conventional suffix (such as Component , Directive , Module , Pipe , or
Service ) for a thing of that type.
Do give the filename the conventional suffix (such as .component.ts , .directive.ts , .module.ts , .pipe.ts , or
.service.ts ) for a file of that type.
Why? Consistent conventions make it easy to quickly identify and reference assets of different types.
/
Symbol Name File Name
@Injectable() user-profile.service.ts
export class UserProfileService { }
Back to top
Service names
Style 02-04
Do use consistent names for all services named after their feature.
Do suffix a service class name with Service . For example, something that gets data or heroes should be called a
DataService or a HeroService .
/
A few terms are unambiguously services. They typically indicate agency by ending in "-er". You may prefer to name a
service that logs messages Logger rather than LoggerService . Decide if this exception is agreeable in your project.
As always, strive for consistency.
Why? Service names such as Credit are nouns and require a suffix and should be named with a suffix when it is not
obvious if it is a service or something else.
@Injectable() hero-data.service.ts
export class HeroDataService { }
@Injectable() credit.service.ts
export class CreditService { }
@Injectable() logger.service.ts
export class Logger { }
Back to top
Bootstrapping
Style 02-05
Do put bootstrapping and platform logic for the app in a file named main.ts .
Avoid putting app logic in main.ts . Instead, consider placing it in a component or service.
/
main.ts
platformBrowserDynamic().bootstrapModule(AppModule)
.then(success => console.log(`Bootstrap success`))
.catch(err => console.error(err));
Back to top
Component selectors
Style 05-02
Why? Keeps the element names consistent with the specification for Custom Elements .
app/heroes/shared/hero-button/hero-button.component.ts
/* avoid */
@Component({
selector: 'tohHeroButton',
templateUrl: './hero-button.component.html'
})
export class HeroButtonComponent {}
app/heroes/shared/hero-button/hero-button.component.ts app/app.component.html
@Component({
selector: 'toh-hero-button',
templateUrl: './hero-button.component.html'
})
export class HeroButtonComponent {}
Back to top
/
Component custom pre x
Style 02-07
Do use a custom prefix for a component selector. For example, the prefix toh represents Tour of Heroes and the
prefix admin represents an admin feature area.
Do use a prefix that identifies the feature area or the app itself.
Why? Prevents element name collisions with components in other apps and with native HTML elements.
Why? Makes it easier to promote and share the component in other apps.
app/heroes/hero.component.ts
/* avoid */
app/users/users.component.ts
/* avoid */
/
app/heroes/hero.component.ts
@Component({
selector: 'toh-hero'
})
export class HeroComponent {}
app/users/users.component.ts
@Component({
selector: 'admin-users'
})
export class UsersComponent {}
Back to top
Directive selectors
Style 02-06
Why? Keeps the names of the properties defined in the directives that are bound to the view consistent with the
attribute names.
Why? The Angular HTML parser is case sensitive and recognizes lower camel case.
Back to top
Do use a custom prefix for the selector of directives (e.g, the prefix toh from Tour of Heroes).
Do spell non-element selectors in lower camel case unless the selector is meant to match a native HTML attribute.
/
app/shared/validate.directive.ts
/* avoid */
@Directive({
selector: '[validate]'
})
export class ValidateDirective {}
app/shared/validate.directive.ts
@Directive({
selector: '[tohValidate]'
})
export class ValidateDirective {}
Back to top
Pipe names
Style 02-09
Do use consistent names for all pipes, named after their feature. The pipe class name should use UpperCamelCase
(the general convention for class names), and the corresponding name string should use lowerCamelCase. The name
string cannot use hyphens ("dash-case" or "kebab-case").
Back to top
/
Unit test le names
Style 02-10
Do name test specification files the same as the component they test.
Components heroes.component.spec.ts
hero-list.component.spec.ts
hero-detail.component.spec.ts
Services logger.service.spec.ts
hero.service.spec.ts
filter-text.service.spec.ts
Pipes ellipsis.pipe.spec.ts
init-caps.pipe.spec.ts
Back to top
Do name end-to-end test specification files after the feature they test with a suffix of .e2e-spec .
Why? Provides pattern matching for test runners and build automation.
/
Test Type File Names
heroes.e2e-spec.ts
Back to top
Do name the module after the feature and folder it resides in.
Why? Upper camel case is conventional for identifying objects that can be instantiated using a constructor.
Why? Easily identifies the module as the root of the same named feature.
Why? A RoutingModule is a module dedicated exclusively to configuring the Angular router. A consistent class and
file name convention make these modules easy to spot and verify.
/
Symbol Name File Name
Back to top
Have a near-term view of implementation and a long-term vision. Start small but keep in mind where the app is
heading down the road.
All of the app's code goes in a folder named src . All feature areas are in their own folder, with their own NgModule.
All content is one asset per file. Each component, service, and pipe is in its own file. All third party vendor scripts are
stored in another folder and not in the src folder. You didn't write them and you don't want them cluttering src . Use
the naming conventions for files in this guide. Back to top
LIFT
Style 04-01
Do structure the app such that you can Locate code quickly, Identify the code at a glance, keep the Flattest structure
you can, and Try to be DRY.
Do define the structure to follow these four basic guidelines, listed in order of importance.
/
Why? LIFT provides a consistent structure that scales well, is modular, and makes it easier to increase developer
efficiency by finding code quickly. To confirm your intuition about a particular structure, ask: can I quickly open and
start work in all of the related files for this feature?
Back to top
Locate
Style 04-02
Why? To work efficiently you must be able to find files quickly, especially when you do not know (or do not
remember) the file names. Keeping related files near each other in an intuitive location saves time. A descriptive
folder structure makes a world of difference to you and the people who come after you.
Back to top
Identify
Style 04-03
Do name the file such that you instantly know what it contains and represents.
Do be descriptive with file names and keep the contents of the file to exactly one component.
Why? Spend less time hunting and pecking for code, and become more efficient. Longer file names are far better
than short-but-obscure abbreviated names.
It may be advantageous to deviate from the one-thing-per-file rule when you have a set of small, closely-
related features that are better discovered and understood in a single file than as multiple files. Be wary
of this loophole.
Back to top
Flat
Style 04-04
Why? No one wants to search for a file through seven levels of folders. A flat structure is easy to scan.
On the other hand, psychologists believe that humans start to struggle when the number of adjacent interesting
things exceeds nine. So when a folder has ten or more files, it may be time to create subfolders.
Base your decision on your comfort level. Use a flatter structure until there is an obvious value to creating a new
folder.
Back to top
Why? Being DRY is important, but not crucial if it sacrifices the other elements of LIFT. That's why it's called T-DRY.
For example, it's redundant to name a template hero-view.component.html because with the .html extension, it is
obviously a view. But if something is not obvious or departs from a convention, then spell it out.
Back to top
Do start small but keep in mind where the app is heading down the road.
Consider creating a folder for a component when it has multiple accompanying files ( .ts , .html , .css and .spec ).
Why? Helps keep the app structure small and easy to maintain in the early stages, while being easy to evolve as the
app grows.
Why? Components often have four files (e.g. *.html , *.css , *.ts , and *.spec.ts ) and can clutter a folder quickly.
<project root>
src
/
app
core
exception.service.ts|spec.ts
user-profile.service.ts|spec.ts
heroes
hero
hero.component.ts|html|css|spec.ts
hero-list
hero-list.component.ts|html|css|spec.ts
shared
hero-button.component.ts|html|css|spec.ts
hero.model.ts
hero.service.ts|spec.ts
heroes.component.ts|html|css|spec.ts
heroes.module.ts
heroes-routing.module.ts
shared
shared.module.ts
init-caps.pipe.ts|spec.ts
filter-text.component.ts|spec.ts
filter-text.service.ts|spec.ts
villains
villain
...
villain-list
...
shared
...
villains.component.ts|html|css|spec.ts
villains.module.ts
villains-routing.module.ts
/
app.component.ts|html|css|spec.ts
app.module.ts
app-routing.module.ts
main.ts
index.html
...
node_modules/...
...
While components in dedicated folders are widely preferred, another option for small apps is to keep
components flat (not in a dedicated folder). This adds up to four files to the existing folder, but also
reduces the folder nesting. Whatever you choose, be consistent.
Back to top
Folders-by-feature structure
Style 04-07
Why? A developer can locate the code and identify what each file represents at a glance. The structure is as flat as it
can be and there are no repetitive or redundant names.
Why? Helps reduce the app from becoming cluttered through organizing the content and keeping them aligned with
the LIFT guidelines.
Why? When there are a lot of files, for example 10+, locating them is easier with a consistent folder structure and
more difficult in a flat structure.
For more information, refer to this folder and file structure example.
Back to top /
App root module
Style 04-08
app/app.module.ts
@NgModule({
imports: [
BrowserModule,
],
declarations: [
AppComponent,
HeroesComponent
],
exports: [ AppComponent ],
entryComponents: [ AppComponent ]
})
export class AppModule {}
Back to top
Feature modules
Style 04-09
Do create an NgModule for all distinct features in an application; for example, a Heroes feature.
Do place the feature module in the same named folder as the feature area; for example, in app/heroes .
Do name the feature module file reflecting the name of the feature area and folder; for example,
app/heroes/heroes.module.ts .
/
Do name the feature module symbol reflecting the name of the feature area, folder, and file; for example,
app/heroes/heroes.module.ts defines HeroesModule .
Why? A feature module can expose or hide its implementation from other modules.
Why? A feature module identifies distinct sets of related components that comprise the feature area.
Why? A feature module can easily be routed to both eagerly and lazily.
Why? A feature module defines clear boundaries between specific functionality and other application features.
Why? A feature module helps clarify and make it easier to assign development responsibilities to different teams.
Back to top
Do create a feature module named SharedModule in a shared folder; for example, app/shared/shared.module.ts
defines SharedModule .
Do declare components, directives, and pipes in a shared module when those items will be re-used and referenced
by the components declared in other feature modules.
Consider using the name SharedModule when the contents of a shared module are referenced across the entire
application.
Consider not providing services in shared modules. Services are usually singletons that are provided once for the
entire application or in a particular feature module. There are exceptions, however. For example, in the sample code
that follows, notice that the SharedModule provides FilterTextService . This is acceptable here because the
service is stateless;that is, the consumers of the service aren't impacted by new instances.
Do import all modules required by the assets in the SharedModule ; for example, CommonModule and FormsModule .
Why? SharedModule will contain components, directives and pipes that may need features from another common
module; for example, ngFor in CommonModule .
Do export all symbols from the SharedModule that other feature modules need to use.
Why? SharedModule exists to make commonly used components, directives and pipes available for use in the
templates of components in many other modules.
Avoid specifying app-wide singleton providers in a SharedModule . Intentional singletons are OK. Take care.
/
Why? A lazy loaded feature module that imports that shared module will make its own copy of the service and likely
have undesirable results.
Why? You don't want each module to have its own separate instance of singleton services. Yet there is a real danger
of that happening if the SharedModule provides a service.
src
app
shared
shared.module.ts
init-caps.pipe.ts|spec.ts
filter-text.component.ts|spec.ts
filter-text.service.ts|spec.ts
app.component.ts|html|css|spec.ts
app.module.ts
app-routing.module.ts
main.ts
index.html
...
@NgModule({
imports: [CommonModule, FormsModule],
declarations: [
FilterTextComponent,
InitCapsPipe
],
providers: [FilterTextService],
/
exports: [
CommonModule,
FormsModule,
FilterTextComponent,
InitCapsPipe
]
})
export class SharedModule { }
Back to top
A distinct application feature or workflow may be lazy loaded or loaded on demand rather than when the application
starts.
Do put the contents of lazy loaded features in a lazy loaded folder. A typical lazy loaded folder contains a routing
component, its child components, and their related assets and modules.
Why? The folder makes it easy to identify and isolate the feature content.
Back to top
Avoid allowing modules in sibling and parent folders to directly import a module in a lazy loaded feature.
Why? Directly importing and using a module will load it immediately when the intention is to load it on demand.
Back to top
Components
Components as elements
Style 05-03
Why? Components have templates containing HTML and optional Angular template syntax. They display content.
Developers place components on the page as they would native HTML elements and web components.
/
Why? It is easier to recognize that a symbol is a component by looking at the template's html.
There are a few cases where you give a component an attribute, such as when you want to augment a
built-in element. For example, Material Design uses this technique with <button mat-button> .
However, you wouldn't use this technique on a custom element.
app/heroes/hero-button/hero-button.component.ts
/* avoid */
@Component({
selector: '[tohHeroButton]',
templateUrl: './hero-button.component.html'
})
export class HeroButtonComponent {}
app/app.component.html
<div tohHeroButton></div>
app/heroes/shared/hero-button/hero-button.component.ts app/app.component.html
@Component({
selector: 'toh-hero-button',
templateUrl: './hero-button.component.html'
})
export class HeroButtonComponent {}
Back to top
Do extract templates and styles into a separate file, when more than 3 lines.
/
Do name the template file [component-name].component.html , where [component-name] is the component name.
Do name the style file [component-name].component.css , where [component-name] is the component name.
Why? Large, inline templates and styles obscure the component's purpose and implementation, reducing readability
and maintainability.
Why? In most editors, syntax hints and code snippets aren't available when developing inline templates and styles.
The Angular TypeScript Language Service (forthcoming) promises to overcome this deficiency for HTML templates
in those editors that support it; it won't help with CSS styles.
Why? A component relative URL requires no change when you move the component files, as long as the files stay
together.
Why? The ./ prefix is standard syntax for relative URLs; don't depend on Angular's current ability to do without that
prefix.
/
app/heroes/heroes.component.ts
/* avoid */
@Component({
selector: 'toh-heroes',
template: `
<div>
<h2>My Heroes</h2>
<ul class="heroes">
<li *ngFor="let hero of heroes | async" (click)="selectedHero=hero">
<span class="badge">{{hero.id}}</span> {{hero.name}}
</li>
</ul>
<div *ngIf="selectedHero">
<h2>{{selectedHero.name | uppercase}} is my hero</h2>
</div>
</div>
`,
styles: [`
.heroes {
margin: 0 0 2em 0;
list-style-type: none;
padding: 0;
width: 15em;
}
.heroes li {
cursor: pointer;
position: relative;
left: 0;
background-color: #EEE;
margin: .5em;
padding: .3em 0;
height: 1.6em;
border-radius: 4px;
}
.heroes .badge {
display: inline-block;
font-size: small;
color: white;
padding: 0.8em 0.7em 0 0.7em;
background-color: #607D8B; /
line-height: 1em;
position: relative;
left: -1px;
top: -4px;
height: 1.8em;
margin-right: .8em;
border-radius: 4px 0 0 4px;
}
`]
})
export class HeroesComponent implements OnInit {
heroes: Observable<Hero[]>;
selectedHero: Hero;
ngOnInit() {
this.heroes = this.heroService.getHeroes();
}
}
@Component({
selector: 'toh-heroes',
templateUrl: './heroes.component.html',
styleUrls: ['./heroes.component.css']
})
export class HeroesComponent implements OnInit {
heroes: Observable<Hero[]>;
selectedHero: Hero;
ngOnInit() {
this.heroes = this.heroService.getHeroes();
}
}
Back to top
/
Decorate input and output properties
Style 05-12
Do use the @Input() and @Output() class decorators instead of the inputs and outputs properties of the
@Directive and @Component metadata:
Consider placing @Input() or @Output() on the same line as the property it decorates.
Why? It is easier and more readable to identify which properties in a class are inputs or outputs.
Why? If you ever need to rename the property or event name associated with @Input() or @Output() , you can
modify it in a single place.
Why? The metadata declaration attached to the directive is shorter and thus more readable.
Why? Placing the decorator on the same line usually makes for shorter code and still easily identifies the property as
an input or output. Put it on the line above when doing so is clearly more readable.
app/heroes/shared/hero-button/hero-button.component.ts
/* avoid */
@Component({
selector: 'toh-hero-button',
template: `<button></button>`,
inputs: [
'label'
],
outputs: [
'heroChange'
]
})
export class HeroButtonComponent {
heroChange = new EventEmitter<any>();
label: string;
}
/
app/heroes/shared/hero-button/hero-button.component.ts
@Component({
selector: 'toh-hero-button',
template: `<button>{{label}}</button>`
})
export class HeroButtonComponent {
@Output() heroChange = new EventEmitter<any>();
@Input() label: string;
}
Back to top
Avoid input and output aliases except when it serves an important purpose.
Why? Two names for the same property (one private, one public) is inherently confusing.
Why? You should use an alias when the directive name is also an input property, and the directive name doesn't
describe the property.
app/heroes/shared/hero-button/hero-button.component.ts
@Component({
selector: 'toh-hero-button',
template: `<button>{{label}}</button>`
})
export class HeroButtonComponent {
// Pointless aliases
@Output('heroChangeEvent') heroChange = new EventEmitter<any>();
@Input('labelAttribute') label: string;
}
/
app/app.component.html
app/heroes/shared/hero-button/hero-button.component.ts app/heroes/shared/hero-button/hero-highlight.dire
@Component({
selector: 'toh-hero-button',
template: `<button>{{label}}</button>`
})
export class HeroButtonComponent {
// No aliases
@Output() heroChange = new EventEmitter<any>();
@Input() label: string;
}
Back to top
Member sequence
Style 05-14
Why? Placing members in a consistent sequence makes it easy to read and helps instantly identify which members
of the component serve which purpose.
/
app/shared/toast/toast.component.ts
/* avoid */
private defaults = {
title: '',
message: 'May the Force be with you'
};
message: string;
title: string;
private toastElement: any;
ngOnInit() {
this.toastElement = document.getElementById('toh-toast');
}
// private methods
private hide() {
this.toastElement.style.opacity = 0;
window.setTimeout(() => this.toastElement.style.zIndex = 0, 400);
}
private show() {
console.log(this.message);
this.toastElement.style.opacity = 1;
this.toastElement.style.zIndex = 9999;
/
app/shared/toast/toast.component.ts
// private fields
private defaults = {
title: '',
message: 'May the Force be with you'
};
private toastElement: any;
// public methods
activate(message = this.defaults.message, title = this.defaults.title) {
this.title = title;
this.message = message;
this.show();
}
ngOnInit() {
this.toastElement = document.getElementById('toh-toast');
}
// private methods
private hide() {
this.toastElement.style.opacity = 0;
window.setTimeout(() => this.toastElement.style.zIndex = 0, 400);
}
private show() {
console.log(this.message);
this.toastElement.style.opacity = 1;
this.toastElement.style.zIndex = 9999;
window.setTimeout(() => this.hide(), 2500);
}
}
Back to top
/
Delegate complex component logic to services
Style 05-15
Do limit logic in a component to only that required for the view. All other logic should be delegated to services.
Do move reusable logic to services and keep components simple and focused on their intended purpose.
Why? Logic may be reused by multiple components when placed within a service and exposed via a function.
Why? Logic in a service can more easily be isolated in a unit test, while the calling logic in the component can be
easily mocked.
Why? Removes dependencies and hides implementation details from the component.
/
app/heroes/hero-list/hero-list.component.ts
/* avoid */
private hideSpinner() {
// hide the spinner
}
}
/
app/heroes/hero-list/hero-list.component.ts
@Component({
selector: 'toh-hero-list',
template: `...`
})
export class HeroListComponent implements OnInit {
heroes: Hero[];
constructor(private heroService: HeroService) {}
getHeroes() {
this.heroes = [];
this.heroService.getHeroes()
.subscribe(heroes => this.heroes = heroes);
}
ngOnInit() {
this.getHeroes();
}
}
Back to top
Do name event handler methods with the prefix on followed by the event name.
Why? Angular allows for an alternative syntax on-* . If the event itself was prefixed with on this would result in an
on-onEvent binding expression.
/
app/heroes/hero.component.ts
/* avoid */
@Component({
selector: 'toh-hero',
template: `...`
})
export class HeroComponent {
@Output() onSavedTheDay = new EventEmitter<boolean>();
}
app/app.component.html
<toh-hero (onSavedTheDay)="onSavedTheDay($event)"></toh-hero>
app/heroes/hero.component.ts app/app.component.html
Back to top
Do put presentation logic in the component class, and not in the template.
Why? Logic will be contained in one place (the component class) instead of being spread in two places.
Why? Keeping the component's presentation logic in the class instead of the template improves testability,
maintainability, and reusability.
/
app/heroes/hero-list/hero-list.component.ts
/* avoid */
@Component({
selector: 'toh-hero-list',
template: `
<section>
Our list of heroes:
<toh-hero *ngFor="let hero of heroes" [hero]="hero">
</toh-hero>
Total powers: {{totalPowers}}<br>
Average power: {{totalPowers / heroes.length}}
</section>
`
})
export class HeroListComponent {
heroes: Hero[];
totalPowers: number;
}
/
app/heroes/hero-list/hero-list.component.ts
@Component({
selector: 'toh-hero-list',
template: `
<section>
Our list of heroes:
<toh-hero *ngFor="let hero of heroes" [hero]="hero">
</toh-hero>
Total powers: {{totalPowers}}<br>
Average power: {{avgPower}}
</section>
`
})
export class HeroListComponent {
heroes: Hero[];
totalPowers: number;
get avgPower() {
return this.totalPowers / this.heroes.length;
}
}
Back to top
Directives
Do use attribute directives when you have presentation logic without a template.
Why? An element may have more than one attribute directive applied.
/
app/shared/highlight.directive.ts
@Directive({
selector: '[tohHighlight]'
})
export class HighlightDirective {
@HostListener('mouseover') onMouseEnter() {
// do highlight work
}
}
app/app.component.html
<div tohHighlight>Bombasta</div>
Back to top
Consider preferring the @HostListener and @HostBinding to the host property of the @Directive and
@Component decorators.
Why? The property associated with @HostBinding or the method associated with @HostListener can be modified
only in a single place—in the directive's class. If you use the host metadata property, you must modify both the
property/method declaration in the directive's class and the metadata in the decorator associated with the directive.
/
app/shared/validator.directive.ts
@Directive({
selector: '[tohValidator]'
})
export class ValidatorDirective {
@HostBinding('attr.role') role = 'button';
@HostListener('mouseenter') onMouseEnter() {
// do work
}
}
Why? The host metadata is only one term to remember and doesn't require extra ES imports.
app/shared/validator2.directive.ts
@Directive({
selector: '[tohValidator2]',
host: {
'[attr.role]': 'role',
'(mouseenter)': 'onMouseEnter()'
}
})
export class Validator2Directive {
role = 'button';
onMouseEnter() {
// do work
}
}
Back to top
Services
Do use services as singletons within the same injector. Use them for sharing data and functionality.
Why? Services are ideal for sharing methods across a feature area or an app.
app/heroes/shared/hero.service.ts
getHeroes() {
return this.http.get<Hero[]>('api/heroes');
}
}
Back to top
Single responsibility
Style 07-02
Do create a new service once the service begins to exceed that singular purpose.
Why? When a service has multiple responsibilities, every component or service that injects it now carries the weight
of them all.
Back to top
Providing a service
Style 07-03
Do provide a service with the app root injector in the @Injectable decorator of the service.
Why? When you provide the service to a root injector, that instance of the service is shared and available in every
class that needs the service. This is ideal when a service is sharing methods or state.
/
Why? When you register a service in the @Injectable decorator of the service, optimization tools such as those
used by the Angular CLI's production builds can perform tree shaking and remove services that aren't used by your
app.
Why? This is not ideal when two different components need different instances of a service. In this scenario it would
be better to provide the service at the component level that needs the new and separate instance.
src/app/treeshaking/service.ts
@Injectable({
providedIn: 'root',
})
export class Service {
}
Back to top
Do use the @Injectable() class decorator instead of the @Inject parameter decorator when using types as tokens
for the dependencies of a service.
Why? The Angular Dependency Injection (DI) mechanism resolves a service's own dependencies based on the
declared types of that service's constructor parameters.
Why? When a service accepts only dependencies associated with type tokens, the @Injectable() syntax is much
less verbose compared to using @Inject() on each individual constructor parameter.
app/heroes/shared/hero-arena.service.ts
/* avoid */
/
app/heroes/shared/hero-arena.service.ts
@Injectable()
export class HeroArena {
constructor(
private heroService: HeroService,
private http: HttpClient) {}
}
Back to top
Data Services
Do refactor logic for making data operations and interacting with data to a service.
Do make data services responsible for XHR calls, local storage, stashing in memory, or any other data operations.
Why? The component's responsibility is for the presentation and gathering of information for the view. It should not
care how it gets the data, just that it knows who to ask for it. Separating the data services moves the logic on how to
get it to the data service, and lets the component be simpler and more focused on the view.
Why? This makes it easier to test (mock or real) the data calls when testing a component that uses a data service.
Why? The details of data management, such as headers, HTTP methods, caching, error handling, and retry logic, are
irrelevant to components and other data consumers.
A data service encapsulates these details. It's easier to evolve these details inside the service without affecting its
consumers. And it's easier to test the consumers with mock service implementations.
Back to top
Lifecycle hooks
Back to top
Why? Lifecycle interfaces prescribe typed method signatures. Use those signatures to flag spelling and syntax
mistakes.
app/heroes/shared/hero-button/hero-button.component.ts
/* avoid */
@Component({
selector: 'toh-hero-button',
template: `<button>OK<button>`
})
export class HeroButtonComponent {
onInit() { // misspelled
console.log('The component is initialized');
}
}
app/heroes/shared/hero-button/hero-button.component.ts
@Component({
selector: 'toh-hero-button',
template: `<button>OK</button>`
})
export class HeroButtonComponent implements OnInit {
ngOnInit() {
console.log('The component is initialized');
}
}
Back to top
Appendix
Back to top
Codelyzer
/
Style A-01
Back to top
Do use file templates or snippets to help follow consistent styles and patterns. Here are templates and/or snippets
for some of the web development editors and IDEs.
Consider using snippets for Visual Studio Code that follow these styles and guidelines.
Consider using snippets for Atom that follow these styles and guidelines.
Consider using snippets for Sublime Text that follow these styles and guidelines.
Consider using snippets for Vim that follow these styles and guidelines.
Back to top