Error invalid link #10288
Open
Error invalid link #10288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
This PR adds visual error feedback for invalid links and email inputs in record details, implementing red border indicators and validation handling across table and inline cell components.
- Added
hasRecordInlineCellDangerBorderScopedStateandhasRecordTableCellDangerBorderScopedStatein/packages/twenty-front/src/modules/object-record/record-inline-cell/statesand/record-table/record-table-cell/statesfor error state management - Enhanced
OverlayContainerin/packages/twenty-front/src/modules/ui/layout/overlay/components/OverlayContainer.tsxwithhasDangerBorderprop for visual feedback - Implemented validation in
EmailsFieldInputandLinksFieldInputusingemailSchemaandabsoluteUrlSchemarespectively - Added error handling callbacks in
RecordInlineCellandRecordTableCellcomponents to manage error states - Integrated error feedback through
MultiItemFieldInputandMultiItemBaseInputcomponents for consistent validation display
12 file(s) reviewed, 9 comment(s)
Edit PR Review Bot Settings | Greptile
...front/src/modules/object-record/record-field/meta-types/input/components/LinksFieldInput.tsx
Show resolved
Hide resolved
...t/src/modules/object-record/record-field/meta-types/input/components/MultiItemFieldInput.tsx
Show resolved
Hide resolved
...es/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCell.tsx
Outdated
Show resolved
Hide resolved
...y-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellEditMode.tsx
Outdated
Show resolved
Hide resolved
.../modules/object-record/record-table/record-table-cell/components/RecordTableCellEditMode.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/overlay/components/OverlayContainer.tsx
Outdated
Show resolved
Hide resolved
...ct-record/record-table/record-table-cell/states/hasRecordTableCellDangerBorderScopedState.ts
Show resolved
Hide resolved
...odules/object-record/record-table/record-table-cell/components/RecordTableCellFieldInput.tsx
Outdated
Show resolved
Hide resolved
...odules/object-record/record-table/record-table-cell/components/RecordTableCellFieldInput.tsx
Show resolved
Hide resolved
|
@etiennejouan Thanks for the update. Sorry, I have been swamped with my job recently 😔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't have access to push on #9942, so close it and open new PR here
Ok for RecordInlineCell / RecordTableCell and EmailsFieldInput / LinksFieldInput.
I think it's too complex for a so small issue (agree with you khuddite)
closes #9778
on top of #9942 from @khuddite