Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error invalid link #10288

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open
Prev Previous commit
Next Next commit
fix from greptile review
  • Loading branch information
etiennejouan committed Feb 18, 2025
commit 4f770f90cfad6c54a2a581cc53851cc2e5f8ac39
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const RecordInlineCell = ({ loading }: RecordInlineCellProps) => {

const setHasRecordInlineCellDangerBorder = useSetRecoilState(
hasRecordInlineCellDangerBorderScopedState(
recordId + fieldDefinition.fieldMetadataId,
`${recordId}-${fieldDefinition.fieldMetadataId}`,
),
);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const RecordInlineCellEditMode = ({

const hasRecordInlineCellDangerBorder = useRecoilValue(
hasRecordInlineCellDangerBorderScopedState(
recordId + fieldDefinition.fieldMetadataId,
`${recordId}-${fieldDefinition.fieldMetadataId}`,
),
);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const RecordTableCellEditMode = ({

const hasRecordTableCellDangerBorder = useRecoilValue(
hasRecordTableCellDangerBorderScopedState(
recordId + fieldDefinition.fieldMetadataId,
`${recordId}-${fieldDefinition.fieldMetadataId}`,
),
);
const { refs, floatingStyles } = useFloating({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const RecordTableCellFieldInput = () => {

const setHasRecordTableCellDangerBorder = useSetRecoilState(
hasRecordTableCellDangerBorderScopedState(
recordId + fieldDefinition.fieldMetadataId,
`${recordId}-${fieldDefinition.fieldMetadataId}`,
),
);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const OverlayContainer = styled.div<{
background: ${({ theme }) => theme.background.transparent.primary};
border: 1px solid
${({ theme, hasDangerBorder }) =>
hasDangerBorder ? theme.border.color.danger : theme.border.color.medium};
theme.border.color[hasDangerBorder ? 'danger' : 'medium']};
box-shadow: ${({ theme }) => theme.boxShadow.strong};

overflow: hidden;
Expand Down
Loading